Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343188: Investigate ways to simplify MemorySegment::ofBuffer #21764

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Oct 29, 2024

This PR proposes to improve MemorySegment::ofBuffer making it more amenable to inlining and generally improving performance.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343188: Investigate ways to simplify MemorySegment::ofBuffer (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21764/head:pull/21764
$ git checkout pull/21764

Update a local copy of the PR:
$ git checkout pull/21764
$ git pull https://git.openjdk.org/jdk.git pull/21764/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21764

View PR using the GUI difftool:
$ git pr show -t 21764

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21764.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2024

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant