Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342486: Implement JEP draft: Structured Concurrency (Fourth Preview) #21760

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Oct 29, 2024

Work in progress.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8342487 to be approved

Issues

  • JDK-8342486: Implement JEP draft: Structured Concurrency (Fourth Preview) (Enhancement - P3)
  • JDK-8342487: Implement JEP draft: Structured Concurrency (Fourth Preview) (CSR)

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21760/head:pull/21760
$ git checkout pull/21760

Update a local copy of the PR:
$ git checkout pull/21760
$ git pull https://git.openjdk.org/jdk.git pull/21760/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21760

View PR using the GUI difftool:
$ git pr show -t 21760

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21760.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2024

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 29, 2024
@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@AlanBateman The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@AlanBateman
Copy link
Contributor Author

/label compiler remove

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@AlanBateman
The label remove is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@AlanBateman
Copy link
Contributor Author

/label remove compiler

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@AlanBateman
The compiler label was successfully removed.

@AlanBateman
Copy link
Contributor Author

AlanBateman commented Oct 29, 2024

/contributor add @AlanBateman
/contributor add @viktorklang-ora

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@AlanBateman
Contributor Alan Bateman <[email protected]> successfully added.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@AlanBateman
Contributor Viktor Klang <[email protected]> successfully added.

* @since 21
*/
@PreviewFeature(feature = PreviewFeature.Feature.STRUCTURED_CONCURRENCY)
public class StructuredTaskScope<T> implements AutoCloseable {
private final ThreadFactory factory;
public class StructuredTaskScope<T, R> implements AutoCloseable {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class can be final given that it only has private constructors.

Suggested change
public class StructuredTaskScope<T, R> implements AutoCloseable {
public final class StructuredTaskScope<T, R> implements AutoCloseable {

@AlanBateman AlanBateman changed the title 8342486: Implementation of Structured Concurrency (Fourth Preview) 8342486: Implement JEP draft: Structured Concurrency (Fourth Preview) Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] csr Pull request needs approved CSR before integration
Development

Successfully merging this pull request may close these issues.

2 participants