-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF #21502
base: master
Are you sure you want to change the base?
8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF #21502
Conversation
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
@Hamlin-Li This change is no longer ready for integration - check the PR body for details. |
@Hamlin-Li The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/contributor add @XiaohongGong |
@Hamlin-Li |
Co-authored-by: Magnus Ihse Bursie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build changes look fine.
/reviewers 3
Hi,
Can you help to review the patch? Previously it's #18605.
This pr is based on #20781.
Thanks!
Test
tests:
options:
Performance
Tests
jmh tests are test/micro/org/openjdk/bench/jdk/incubator/vector/operation/ from vectorIntrinsics branch in panama-vector. It's good to have these tests in jdk main stream, I will do it in a separate pr later. (These tests are auto-generated tests from some script&template, it's good to also have those scrip&template in jdk main stream, but those scrip&template generates more other tests than what we need here, so better to add these tests and script&template in another pr).
Options
Performance data
I have re-tested, there is no much difference from #18605, so please check performance data in that pr.
Progress
Issue
Reviewers
Contributors
<[email protected]>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21502/head:pull/21502
$ git checkout pull/21502
Update a local copy of the PR:
$ git checkout pull/21502
$ git pull https://git.openjdk.org/jdk.git pull/21502/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21502
View PR using the GUI difftool:
$ git pr show -t 21502
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21502.diff
Webrev
Link to Webrev Comment