Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF #21502

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Oct 14, 2024

Hi,
Can you help to review the patch? Previously it's #18605.
This pr is based on #20781.

Thanks!

Test

tests:

  • test/jdk/jdk/incubator/vector/
  • test/hotspot/jtreg/compiler/vectorapi/

options:

  • -XX:UseSVE=1 -XX:+EnableVectorSupport -XX:+UseVectorStubs
  • -XX:UseSVE=0 -XX:+EnableVectorSupport -XX:+UseVectorStubs
  • -XX:+EnableVectorSupport -XX:-UseVectorStubs

Performance

Tests

jmh tests are test/micro/org/openjdk/bench/jdk/incubator/vector/operation/ from vectorIntrinsics branch in panama-vector. It's good to have these tests in jdk main stream, I will do it in a separate pr later. (These tests are auto-generated tests from some script&template, it's good to also have those scrip&template in jdk main stream, but those scrip&template generates more other tests than what we need here, so better to add these tests and script&template in another pr).

Options

  • +intrinsic: 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions -XX:+EnableVectorSupport -XX:+UseVectorStubs'
  • -intrinsic: 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions -XX:+EnableVectorSupport -XX:-UseVectorStubs'

Performance data

I have re-tested, there is no much difference from #18605, so please check performance data in that pr.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (3 reviews required, with at least 1 Reviewer, 2 Authors)

Issue

  • JDK-8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF (Enhancement - P4)

Reviewers

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21502/head:pull/21502
$ git checkout pull/21502

Update a local copy of the PR:
$ git checkout pull/21502
$ git pull https://git.openjdk.org/jdk.git pull/21502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21502

View PR using the GUI difftool:
$ git pr show -t 21502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21502.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@Hamlin-Li This change is no longer ready for integration - check the PR body for details.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@Hamlin-Li The following labels will be automatically applied to this pull request:

  • build
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@Hamlin-Li Hamlin-Li marked this pull request as ready for review October 15, 2024 08:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 15, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2024

Webrevs

@Hamlin-Li
Copy link
Author

/contributor add @XiaohongGong

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@Hamlin-Li
Contributor Xiaohong Gong <[email protected]> successfully added.

Co-authored-by: Magnus Ihse Bursie <[email protected]>
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build changes look fine.

/reviewers 3

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 15, 2024
@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@magicus
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 3 (with at least 1 Reviewer, 2 Authors).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants