8333725: Compiler Prototyping for Deconstructors #94

biboudis · 2024-05-13T14:10:31Z

Work-in-progress prototyping of deconstructors.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8333725: Compiler Prototyping for Deconstructors (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/amber.git pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.org/amber.git pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/amber/pull/94.diff

bridgekeeper · 2024-05-13T14:11:17Z

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-05-13T14:11:29Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2024-05-13T14:12:11Z

@biboudis this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout matchers-experiment
git fetch https://git.openjdk.org/amber.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk · 2024-05-13T14:23:28Z

⚠️ @biboudis This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

vicente-romero-oracle · 2024-06-01T00:18:38Z

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

@@ -4286,6 +4366,70 @@ public void visitRecordPattern(JCRecordPattern tree) {
        matchBindings = new MatchBindings(outBindings.toList(), List.nil());
    }

+    // todo: follow the protocol in Resolve::selectBest


this method I think belongs in Resolve

vicente-romero-oracle · 2024-06-01T00:23:48Z

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java

@@ -2779,6 +2779,32 @@ public void visitMethodDef(JCMethodDecl tree) {
                syms.methodClass);
        }

+        if (tree.sym.isPattern()) {
+            tree.sym.flags_field  |= STATIC;
+            tree.sym.flags_field  |= SYNTHETIC;


we are making synthetic an AST that actually appears in the source?

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java

test/test/Point.class

vicente-romero-oracle · 2024-06-04T15:20:30Z

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

+                expectedRecordTypes = record.getRecordComponents()
+                                            .stream()
+                                            .map(rc -> types.memberType(site, rc))
+                                            .map(t -> types.upward(t, types.captures(t)).baseType())


not sure why the upward projection is used here

src/java.base/share/classes/java/lang/Class.java

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/MemberEnter.java

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Items.java

vicente-romero-oracle · 2024-06-06T21:04:11Z

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/PoolWriter.java

@@ -201,7 +202,7 @@ int putName(Name name) {
     * Puts a name and type pair into the pool and returns its index.
     */
    int putNameAndType(Symbol s) {
-        return pool.writeIfNeeded(new NameAndType(s.name, descriptorType(s)));
+        return pool.writeIfNeeded(new NameAndType(s instanceof MethodSymbol ms ? ms.externalName(types) : s.name, descriptorType(s)));


same not sure why you need this change

Co-authored-by: Angelos Bimpoudis <[email protected]> Co-authored-by: Jan Lahoda <[email protected]> Co-authored-by: Vicente Romero <[email protected]>

…o matchers-experiment # Conflicts: # src/java.base/share/classes/java/lang/Class.java

biboudis · 2024-08-13T13:34:53Z

Keep it, keep it, keep it.

* A crude sketch of unreflect for deconstructors. * Reuse the same mangling everywhere. * Cleanup.

Co-authored-by: Viktor Klang <[email protected]>

* Switching to Carriers.boxedComponentValueArray * Fixing UnreflectPattern

* Introduce Deconstructor <: MemberPattern <: Executable * Fix MemberPattern.setAccessible * Retain signature of unreflectDeconstructor

bridgekeeper · 2024-10-08T19:41:45Z

@biboudis This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Rick-24 · 2024-10-08T19:42:32Z

Hi @Rick-24, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK [Terms of Use](https://openjdk.java.net/legal/tou/). If you already are an OpenJDK [Author](https://openjdk.java.net/bylaws#author), [Committer](https://openjdk.java.net/bylaws#committer) or [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1) to open a new issue so that we can record that fact. Please Use "Add GitHub user Rick-24" for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.  - [ ] I agree to the [OpenJDK Terms of Use](https://openjdk.java.net/legal/tou/) for all comments I make in a project in the [OpenJDK GitHub organization](https://github.com/openjdk).  Your comment will be automatically restored once you have accepted the OpenJDK [Terms of Use](https://openjdk.java.net/legal/tou/).

biboudis · 2024-10-09T09:04:24Z

Definitely keep it open :D

…periment # Conflicts: # src/java.base/share/classes/java/lang/classfile/AccessFlags.java # src/java.base/share/classes/java/lang/classfile/Attribute.java # src/java.base/share/classes/java/lang/classfile/AttributedElement.java # src/java.base/share/classes/java/lang/classfile/MethodElement.java # src/java.base/share/classes/java/lang/reflect/ReflectAccess.java # src/java.base/share/classes/jdk/internal/classfile/impl/ClassRemapperImpl.java # src/java.base/share/classes/jdk/internal/classfile/impl/UnboundAttribute.java # src/java.base/share/native/libjava/Class.c # src/java.compiler/share/classes/javax/lang/model/element/Modifier.java # src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitorPreview.java # src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java # src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java # test/jdk/jdk/classfile/StackMapsTest.java

…periment # Conflicts: # src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java

- Fix crash when assigning to bindings - Disallow pattern no matching on all control paths Co-authored-by: Jan Lahoda <[email protected]>

… to deconstructors

# Conflicts: # test/jdk/jdk/classfile/StackMapsTest.java

…periment # Conflicts: # src/java.base/share/classes/java/lang/reflect/Constructor.java

openjdk bot added the merge-conflict The pull request has a merge conflict with the target branch label May 13, 2024

biboudis marked this pull request as draft May 13, 2024 14:20

openjdk bot removed the merge-conflict The pull request has a merge conflict with the target branch label May 13, 2024

biboudis force-pushed the matchers-experiment branch from d635684 to ccc44d4 Compare May 27, 2024 11:24

vicente-romero-oracle reviewed Jun 1, 2024

View reviewed changes

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java Outdated Show resolved Hide resolved

vicente-romero-oracle reviewed Jun 1, 2024

View reviewed changes

test/test/Point.class Outdated Show resolved Hide resolved

openjdk bot added the merge-conflict The pull request has a merge conflict with the target branch label Jun 3, 2024

vicente-romero-oracle reviewed Jun 4, 2024

View reviewed changes

openjdk bot removed the merge-conflict The pull request has a merge conflict with the target branch label Jun 6, 2024

biboudis force-pushed the matchers-experiment branch from 6138923 to 5246297 Compare June 6, 2024 13:46

biboudis changed the title ~~Pattern Declarations~~ Compiler Prototyping for Deconstructors Jun 6, 2024

biboudis changed the title ~~Compiler Prototyping for Deconstructors~~ 8333725: Compiler Prototyping for Deconstructors Jun 6, 2024

biboudis force-pushed the matchers-experiment branch 2 times, most recently from bf45138 to 250d702 Compare June 6, 2024 14:12

vicente-romero-oracle reviewed Jun 6, 2024

View reviewed changes

biboudis force-pushed the matchers-experiment branch from 250d702 to a19eff9 Compare June 6, 2024 21:13

8333725: Compiler Prototyping for Deconstructors

4c7b0ba

Co-authored-by: Angelos Bimpoudis <[email protected]> Co-authored-by: Jan Lahoda <[email protected]> Co-authored-by: Vicente Romero <[email protected]>

biboudis force-pushed the matchers-experiment branch from a19eff9 to 4c7b0ba Compare June 7, 2024 07:42

Fix translation of dtors with primitives and array types

61327bf

openjdk bot added the merge-conflict The pull request has a merge conflict with the target branch label Jun 17, 2024

Merge remote-tracking branch 'refs/remotes/upstream-amber/master' int…

80a3f46

…o matchers-experiment # Conflicts: # src/java.base/share/classes/java/lang/Class.java

openjdk bot removed the merge-conflict The pull request has a merge conflict with the target branch label Jun 17, 2024

biboudis added 2 commits June 17, 2024 16:14

Restore JTreg flag

875eb34

Address review 1/n

0eab5db

biboudis and others added 8 commits August 30, 2024 15:26

Fix exhaustiveness bug

84d94ff

A crude sketch for Lookup.unreflectDeconstructor (#7)

09d8083

* A crude sketch of unreflect for deconstructors. * Reuse the same mangling everywhere. * Cleanup.

Fix uniqueness of patterns

69d7f7f

Fix resolved pattern declaration resolution check for null

c3b8f0e

Resolve unreflected deconstructor to work with invokeExact

09128ed

Co-authored-by: Viktor Klang <[email protected]>

Switching to Carriers.boxedComponentValueArray (#8)

512193a

* Switching to Carriers.boxedComponentValueArray * Fixing UnreflectPattern

Introduce Deconstructor <: MemberPattern <: Executable (#9)

934602d

* Introduce Deconstructor <: MemberPattern <: Executable * Fix MemberPattern.setAccessible * Retain signature of unreflectDeconstructor

Add instanceof statement (#10)

58bfec1

liach mentioned this pull request Oct 10, 2024

8199429: [lworld] value type (re)constructors expressions value type should not be discardable openjdk/valhalla#1274

Open

1 task

Remove VM preliminary work

c1c4e60

openjdk bot removed the merge-conflict The pull request has a merge conflict with the target branch label Oct 31, 2024

biboudis force-pushed the matchers-experiment branch from a3133eb to f5c926b Compare November 1, 2024 16:22

openjdk bot added the merge-conflict The pull request has a merge conflict with the target branch label Nov 1, 2024

Merge remote-tracking branch 'upstream-amber/master' into matchers-ex…

b8cbc6f

…periment # Conflicts: # src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java

openjdk bot removed the merge-conflict The pull request has a merge conflict with the target branch label Nov 1, 2024

biboudis force-pushed the matchers-experiment branch 2 times, most recently from b856cb6 to 7fbda10 Compare November 3, 2024 11:37

Fix crashes

522cf97

- Fix crash when assigning to bindings - Disallow pattern no matching on all control paths Co-authored-by: Jan Lahoda <[email protected]>

biboudis force-pushed the matchers-experiment branch from 7fbda10 to 522cf97 Compare November 3, 2024 11:38

biboudis added 6 commits November 4, 2024 10:38

Fix target checking for ElementType.DECONSTRUCTOR/METHOD when applied…

2837063

… to deconstructors

Fix examples

fdeeb84

Merge branch 'master' into matchers-experiment

509c1ed

# Conflicts: # test/jdk/jdk/classfile/StackMapsTest.java

Invoke Patterns through PatternBootstraps

4b4a760

Fix imports

b71d7ef

Merge remote-tracking branch 'upstream-amber/master' into matchers-ex…

d7c8539

…periment # Conflicts: # src/java.base/share/classes/java/lang/reflect/Constructor.java

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8333725: Compiler Prototyping for Deconstructors #94

8333725: Compiler Prototyping for Deconstructors #94

biboudis commented May 13, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented May 13, 2024

openjdk bot commented May 13, 2024

openjdk bot commented May 13, 2024

openjdk bot commented May 13, 2024

vicente-romero-oracle Jun 1, 2024

vicente-romero-oracle Jun 1, 2024

vicente-romero-oracle Jun 4, 2024

vicente-romero-oracle Jun 6, 2024

biboudis commented Aug 13, 2024

bridgekeeper bot commented Oct 8, 2024

Rick-24 commented Oct 8, 2024 via email •

edited by bridgekeeper bot

Loading

biboudis commented Oct 9, 2024

8333725: Compiler Prototyping for Deconstructors #94

Are you sure you want to change the base?

8333725: Compiler Prototyping for Deconstructors #94

Conversation

biboudis commented May 13, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewing

bridgekeeper bot commented May 13, 2024

openjdk bot commented May 13, 2024

openjdk bot commented May 13, 2024

openjdk bot commented May 13, 2024

vicente-romero-oracle Jun 1, 2024

Choose a reason for hiding this comment

vicente-romero-oracle Jun 1, 2024

Choose a reason for hiding this comment

vicente-romero-oracle Jun 4, 2024

Choose a reason for hiding this comment

vicente-romero-oracle Jun 6, 2024

Choose a reason for hiding this comment

biboudis commented Aug 13, 2024

bridgekeeper bot commented Oct 8, 2024

Rick-24 commented Oct 8, 2024 via email • edited by bridgekeeper bot Loading

biboudis commented Oct 9, 2024

biboudis commented May 13, 2024 •

edited by openjdk bot

Loading

Rick-24 commented Oct 8, 2024 via email •

edited by bridgekeeper bot

Loading