-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some compilation errors on different platforms #64
Conversation
Cool! Two minor thing:
|
I will work on this pull request in October. |
- Linux already has a getopt() function via unistd.h
Hi. I cherrypicked the PR and now only the compilation fixes are included. |
Where did you find the above line? I grepped the code for "unix" and most of the time "#if defined (unix)" is used. Maybe we should agree on some definition and then change it everywhere in the code to the same.
I do not know. I will try out when I find some time for that. |
@othiman About pshar: it will probably be removed. |
@dennisguse I found a very nice site which addresses this issue: I think we should use |
@othiman You are right - this looks better. I think this is quite some manual effort. PS: Could this pull request be closed? |
Another thing is, what platforms should be supported in the future? E.g., it seems not very reasonable to continue supporting the VMS platform. Anyhow, this PR is outdated, so I close it. |
Hi.
I fixed some compilation errors on Windows and Linux and added a .gitignore file to unclutter the git status command. This should at least fix #63.
I would be happy if you could include these patches into the dev branch.
Best regards,
Thomas