Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update Verilator version to v5.008 #1566

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

saadwaheed-10xe
Copy link
Contributor

This PR updates the Verilator version to v5.008 in the CI #1558.

@github-actions
Copy link
Contributor

✔️ successful run, report available here.

@github-actions
Copy link
Contributor

✔️ successful run, report available here.

Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks!

@zarubaf
Copy link
Contributor

zarubaf commented Oct 23, 2023

Do you think you can mark it as ready (only if you are of course)? And fix the failing Eclipse check? You need to sign the committee agreement on eclipse and sign all your commits (git commit -s --amend --no-edit --reset-author if you want to be brief :-)).

@saadwaheed-10xe
Copy link
Contributor Author

Thanks @zarubaf. I have fixed the failing Eclipse check and marked the PR ready.

@saadwaheed-10xe saadwaheed-10xe marked this pull request as ready for review October 23, 2023 17:48
@github-actions
Copy link
Contributor

✔️ successful run, report available here.

@zarubaf zarubaf merged commit 5841984 into openhwgroup:master Oct 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants