Allow concurrent actions on packages #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows package dependencies to be read into a dependency tree. From this tree we are able to determine which package actions can be run concurrently. This allows us to drastically speed up the time it takes to deploy packages.
I don't think this is useful and makes the table really wide which causes display issues.
|
Task linked: CU-86by2x2u5 Start platform packages concurrenctly |
rcrichton
changed the title
marrouchi
requested changes
Apr 19, 2024
BMartinos
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
@rcrichton Looks great to me 👍
Just a few minor questions but approved from my end 🚀
marrouchi
previously approved these changes
Apr 19, 2024
marrouchi
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow instant to operate on packages concurrently, which dramtically speeds up the time taken to deploy multiple packages. It takes into account dependencies and only those packages it can safely deploy while waiting for dependencies to be available before allowing dependant packages to execute. The default concurreny is set to 5. This can be configred but requires changes in the go CLI for this configuration to be exposed.