-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding validator for files on converter to cloud project #614
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add such function in file utils.
Also the pattern is a bit more complex, expecially for windows. Can we use something like this:
\A(?!(?:COM[0-9]|CON|LPT[0-9]|NUL|PRN|AUX|com[0-9]|con|lpt[0-9]|nul|prn|aux)|\s|[\.]{2,})[^\\\/:*"?<>|]{1,254}(?<![\s\.])\z
Even better, we can check if pathvalidate
is installed and use that, otherwise fallback to the above regex (or better one). Don't forget to check if the file path is also correct.
Thank you. Due to the library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the ProjectChecker
for providing this kind of feedback? There is already ASCII filename warnings, the file one to be added should be an error that prevents further actions with the project.
Co-authored-by: Ivan Ivanov <[email protected]>
For this it will be require to add a method to libqfieldsync |
Can you add a screencast how this works? Code looks good enough for now. |
@suricactus There in the up is with when the message is directly on QFieldSync on the down when is using the libqfieldsync Using directly QFieldSyncdirectly_on_qfield_sync.mp4Using libqfieldsyncusing_libqfieldsync.mp4My vote is for opt for the libqfieldsync option, also is already for create a PR |
No description provided.