✨(frontend) add open edx profile information in learner dashboard

[rlecellier]

Purpose

• display language when open edx return it.

Missing parts:

• openEdx endpoint do not return language

[rlecellier]

@jbpenrath
Why does this route use api/user/v1/ where other api route use /api/v1.0/user ?

[jbpenrath]

/api/v1.0/user are routes developed by us in fonzie so we follow versionned route pattern we are using in our projects.

api/user/v1/ are routes of OpenEdX.

[jbpenrath]

Last comments batch then LGTM ✅

[jbpenrath]

Suggested change

	get: (username: string) => {
	return Promise.resolve({
	username: 'j_do',
	name: 'John Do',
	email: '[email protected]',
	country: 'fr',
	level_of_education: OpenEdxLevelOfEducation.MASTER_OR_PROFESSIONNAL_DEGREE,
	gender: OpenEdxGender.MALE,
	year_of_birth: '1971',
	'pref-lang': OpenEdxLanguageIsoCode.ENGLISH,
	language_proficiencies: [{ code: OpenEdxLanguageIsoCode.ENGLISH }],
	} as OpenEdxApiProfile);
	get: (username: string): Promise<OpenEdxApiProfile> => {
	return Promise.resolve({
	NathanVss marked this conversation as resolved.
	username: 'j_do',
	name: 'John Do',
	email: '[email protected]',
	country: 'fr',
	level_of_education: OpenEdxLevelOfEducation.MASTER_OR_PROFESSIONNAL_DEGREE,
	gender: OpenEdxGender.MALE,
	year_of_birth: '1971',
	'pref-lang': OpenEdxLanguageIsoCode.ENGLISH,
	date_joined: '1970-01-01T00:00:00Z'
	language_proficiencies: [{ code: OpenEdxLanguageIsoCode.ENGLISH }],
	});

[rlecellier]

Why defined the type again where it's already done in types/api.ts ?

export interface APIAuthentication {
  login: () => void;
  logout: () => Promise<void>;
  me: () => Promise<Nullable<User>>;
  register: () => void;
  // routes below are only defined for fonzie auth backend
  accessToken?: () => Nullable<string>;
  account?: {
    get: (username: string) => Promise<OpenEdxApiProfile>;
  };
}

[jbpenrath]

Indeed you could remove the returned type. By purpose was mainly to remove the as OpenEdxApiProfile