-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser unsaved changes modal when navigation form order sumary page [OFN-11600] #12836
base: master
Are you sure you want to change the base?
Conversation
5dc3311
to
fbfb429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wandji20! Thank you for working on this. I noticed a few minor issues that need attention. Could you please take a look when you have a moment? Thanks so much!
Edit:
The failing specs are unrelated.
fbfb429
to
481e9d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 , Thanks !
What? Why?
Show pop-in alert when navigating away from the summary page without placing an order
What should we test?
Navigating away from the order summary page will now show the default browser popup
With exceptions to
/checkout/summary
Release notes
Show pop-in alert when navigating away from the summary page without placing an order
Changelog Category (reviewers may add a label for the release notes):
Dependencies
N/A
Documentation updates
N/A