Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Added new logo in README.md #4915

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

style: Added new logo in README.md #4915

wants to merge 5 commits into from

Conversation

dmdbilal
Copy link
Contributor

Description

Added new logo in README.md

Related issues

#4832

@dmdbilal dmdbilal requested a review from a team as a code owner February 14, 2023 02:56
@dmdbilal dmdbilal changed the title style : Added new logo in README.md style: Added new logo in README.md Feb 14, 2023
@VaiTon
Copy link
Member

VaiTon commented Feb 18, 2023

We should still use the logo from the static website. Another alternative is to upload the logo to github. With this PR I don't know where is that link pointing

pratyaksh1610
pratyaksh1610 suggested changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@pratyaksh1610 pratyaksh1610 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add a before and after image for easier review and for maintaining history.
Also the test fails. PTAL and send back for review.
Thanks.

@dmdbilal
Copy link
Contributor Author

@VaiTon I've downloaded the logos from the drive that was provided in the issue #4832. If that is not, then where can i get the logos ?

@VaiTon
Copy link
Member

VaiTon commented Feb 22, 2023

@dmdbilal you should do as this does: https://raw.githubusercontent.com/openfoodfacts/.github/main/profile/README.md

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dmdbilal
Copy link
Contributor Author

@VaiTon Can you check now ?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratyaksh1610 pratyaksh1610 pratyaksh1610 requested changes

Assignees

@dmdbilal dmdbilal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmdbilal @VaiTon @pratyaksh1610 @teolemon