Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Prices): Allow adding new prices with a location_id #527

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat(Prices): Allow adding new prices with a location_id #527

merged 2 commits into from
Oct 18, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Oct 18, 2024 •
edited
Loading

What

Update the Price model validation & API to allow users to pass a location_id

  • if a OSM location, then the location_osm_id & location_osm_type are still mandatory and should match
  • if a ONLINE location, then the location_osm_id & location_osm_type should be empty

@raphodn raphodn mentioned this pull request Oct 18, 2024
Closed
5 tasks
@raphodn raphodn marked this pull request as ready for review October 18, 2024 23:30
@raphodn raphodn merged commit 99f16df into main Oct 18, 2024
8 checks passed
@raphodn raphodn deleted the raphodn/price-create-location-id branch October 18, 2024 23:36
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Oct 18, 2024
Merged
@raphodn raphodn mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raphodn raphodn

Labels
None yet
Projects
💸 Open Prices
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raphodn