feat: authentication workflow and store user token #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
raphodn
force-pushed
the
raphodn/setup-authentication-workflow
branch
from
9b92767
to
29e9258
Compare
raphael0202
reviewed
Nov 15, 2023
.env.example
Outdated
| @@ -6,6 +6,7 @@ COMPOSE_PATH_SEPARATOR=; | |||
| COMPOSE_FILE=docker-compose.yml;docker/dev.yml | |||
|
|
|||
| API_PORT=127.0.0.1:8000 | |||
| OAUTH2_SERVER_URL=https://world.openfoodfacts.org/cgi/auth.pl | |||
There was a problem hiding this comment.
We will deploy it in staging as well (https://world.openfoodfacts.net), so the URL need not to be hardcoded. You can use openfoodfacts SDK URLBuilder (https://github.com/openfoodfacts/openfoodfacts-python/blob/develop/openfoodfacts/utils.py#L23) to build OFF URLs this easily.
There was a problem hiding this comment.
if it's in the .env then it's not hardcoded, right ? 😅
I'm not sure how to do this so I'll do it in a seperate PR :)
raphael0202
reviewed
Nov 15, 2023
raphael0202
approved these changes
Nov 15, 2023
raphodn
force-pushed
the
raphodn/setup-user-table
branch
2 times, most recently
from
8750d26
to
2f09505
Compare
raphodn
force-pushed
the
raphodn/setup-authentication-workflow
branch
from
29e9258
to
b47f6d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/authUserdb