feat: update filter library #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael0202
force-pushed
the
add-get-products-endpoint
branch
from
b42ff8e
to
a633df2
Compare
raphodn
reviewed
Jan 5, 2024
| @@ -42,7 +42,7 @@ sqlalchemy = "~2.0.23" | |||
| sqlalchemy-utils = "~0.41.1" | |||
| uvicorn = "~0.23.2" | |||
| fastapi-pagination = "^0.12.12" | |||
| fastapi-filter = "^1.0.0" | |||
| fastapi-filters = "~0.2.9" | |||
There was a problem hiding this comment.
Ah sucks that we have to change filtering library.. Is it a known problem on their side with a tracked issue ? The new library has less users and activity it seems.
There was a problem hiding this comment.
I'll check tomorrow when I get back behind the computer :)
There was a problem hiding this comment.
I ended up doing a PR #122, to seperate at least the new endpoint and this PR that replaces the filtering library. let me know i can take care of the rebase 🙏
There was a problem hiding this comment.
an alternative would be to init unique_scans_n to 0
|
Closing, as it's not required anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from fastapi-filter to https://github.com/uriyyo/fastapi-filters that allow to put null values last when performing a sort.
This is necessary when sorting by
unique_scans_n, as we don't want null values first (we want the most popular first).This is a breaking change in the API, as we cannot exactly mimick the parameters of fastapi-filter.