Android vibration fixes. #1804
Merged
Android vibration fixes. #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MAJigsaw77
commented
Jun 16, 2024
•
MAJigsaw77
commented
- Fixed some deprecation warnings.
- Cancel the vibration when the app is being paused or destroyed.
MAJigsaw77
changed the title
|
@player-03 Can i get a review on this pr? |
player-03
reviewed
Jul 7, 2024
templates/android/template/app/src/main/java/org/haxe/lime/GameActivity.java
Outdated
Show resolved
Hide resolved
I'd rather duplicate the SDK version check, not the math.
|
Interesting. According to the documentation, the first entry in the array is the delay before vibration starts, so they recommend leaving that 0. The question is, is this delay a bug or a feature? If it's a bug, we could fix it now. If it's a feature, we probably want to add an argument to toggle it on or off. |
`GameActivity` doesn't print any other messages, so this seems out of place. Plus, it would happen every time even if there's no vibration ongoing.
I don't really know what to say tbh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.