Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy documentation #1211

Merged
merged 4 commits into from
May 22, 2024
Merged

Deploy documentation #1211

merged 4 commits into from
May 22, 2024

Conversation

MattiSG
Copy link
Member

@MattiSG MattiSG commented May 21, 2024

Technical changes


Proof that the deployment is triggered can be found on the Doc Actions log.

Details of implementation and difficulties can be found on openfisca/openfisca-doc#308 (comment).

I suggest to wait until openfisca/openfisca-doc#309 is merged to proceed with merging this PR, as it would be the ideal moment to change the ref to main rather than having an additional patch published later. The review is still relevant to have now thought, considering that the logic itself will not change.


If this PR is merged:

  • CIRCLECI_OPENFISCADOC_TOKEN secret should be erased
  • CIRCLECI_V1_OPENFISCADOC_TOKEN secret should be erased

@MattiSG MattiSG requested a review from Ndpnt May 21, 2024 18:54
@coveralls
Copy link

Coverage Status

coverage: 74.48%. remained the same
when pulling 005c5c6 on deploy-doc
into 46c7c7e on master.

@MattiSG MattiSG merged commit 8e28b0d into master May 22, 2024
22 checks passed
@MattiSG MattiSG deleted the deploy-doc branch May 22, 2024 07:31
@MattiSG
Copy link
Member Author

MattiSG commented May 22, 2024

Proven to work: this core deploy triggered this doc deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants