Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop latest NumPy supported version to 1.18 #1014

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Drop latest NumPy supported version to 1.18 #1014

merged 2 commits into from
Apr 29, 2021

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Apr 29, 2021

Fixes #1009
Supersedes #1012
Depended on by #1010

Bug fix

This reverts commit 6c05349, reversing
changes made to 3123d27.
@bonjourmauko bonjourmauko added the kind:fix Bugs are defects and failure demand. label Apr 29, 2021
@bonjourmauko bonjourmauko requested a review from a team April 29, 2021 08:55
Copy link
Collaborator

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to #990 content and all seems to be reverted.

I see that this PR isn't the method that we chose with @benjello and @guillett (!= method 2️⃣ on slack) but it was before you analyzed was we did in the past for a similar situation and I agree that this way is cleaner (and doesn't introduce a new way of managing unpublished revisions with its risks).

@sandcha sandcha merged commit aefc897 into master Apr 29, 2021
@sandcha sandcha deleted the downgrade-numpy branch April 29, 2021 17:31
@sandcha sandcha mentioned this pull request Apr 29, 2021
7 tasks
@bonjourmauko
Copy link
Member Author

bonjourmauko commented Apr 29, 2021

Thanks a lot @sandcha !

I see that this PR isn't the method that we chose with @benjello and @guillett (!= method 2️⃣ on slack) but it was before you analysed was we did in the past for a similar situation and I agree that this way is cleaner (and doesn't introduce a new way of managing unpublished revisions with its risks).

Again thanks a lot for your proactiveness to try to find a way to unblock users 😃

There are a couple of factors that convinced me to propose this way of dealing with the issue, and here instead of Slack:

  1. As you mention, it seems that we already have a way of dealing with this situation, but its documentation is largely absent. In general, I think that the whole corpus of previous decisions is an asset we have to take into account —referring to the "jurisprudence" more often and calling "referendums" only in case of dissent as a subsidiary decision-making strategy.

  2. In parallel, I feel the boundary between Github's and Slack's role is rather blurry. This proposal is thus motivated by the following hypothetical rule-of-thumb:

  • OpenFisca's Slack is an éphémère space for mingling, exchange, cross-pollination, etc. Being éphémère renders it IMHO unsuitable for documenting decisions —hence not "opposable".

  • OpenFisca's Slack is also underrepresented when it comes to the core, most of the public discussions (23% of total) being held in the context of the country models. Thus I'm not even sure it is a suitable place for product decision-making.

  • Regarding that previous point: what works for example with France, where we can today with confidence have in a same call a decent amount of contributor's representation, the same does not hold yet true for the core.

  1. Finally I think the fact that we already lack a clear process for maintenance/contribution (Have a clear process for maintenance/contribution #1004) makes it the much more undesirable to further increase information and participation asymmetry: how to weight my opinion, yours, @guillett's, @benjello's, etc., expressed over a semi-public space, in a thread, regarding the whole of the core's users' and contributors' in the context of a decision that will likely impact them all? —it is at least here more a question of transparency than legitimacy, otherwise I wouldn't be writing this comment myself.

This issue is rather easy because of 1. supra —I cheated! 🤣— but others won't be so.

@bonjourmauko bonjourmauko changed the title Drop latest NumPy supported version to 1.18.x Drop latest NumPy supported version to 1.17 May 6, 2021
@bonjourmauko bonjourmauko changed the title Drop latest NumPy supported version to 1.17 Drop latest NumPy supported version to 1.18 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Bugs are defects and failure demand.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenFisca-Core seems to depend on numpy 1.20
2 participants