-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop latest NumPy supported version to 1.18 #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to #990 content and all seems to be reverted.
I see that this PR isn't the method that we chose with @benjello and @guillett (!= method 2️⃣ on slack) but it was before you analyzed was we did in the past for a similar situation and I agree that this way is cleaner (and doesn't introduce a new way of managing unpublished revisions with its risks).
Thanks a lot @sandcha !
Again thanks a lot for your proactiveness to try to find a way to unblock users 😃 There are a couple of factors that convinced me to propose this way of dealing with the issue, and here instead of Slack:
This issue is rather easy because of 1. supra —I cheated! 🤣— but others won't be so. |
Fixes #1009
Supersedes #1012
Depended on by #1010
Bug fix
__future__.annotations
, those stubs or type sheds are casted totyping.Any
typing.TYPE_CHEKING
variablenumpy.typing
module was being imported at runtime, rendering OpenFisca unusable to all users depending on previous versions of NumPy (1.20.x-)