Update pyproject.toml to include licence and reorder to match officia… #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
verbman
commented
May 12, 2024
verbman
commented
- Technical improvement.
- Minor
- Details:
- Add licence to pyproject.toml, reorder to match official pyproject.toml example
MattiSG
reviewed
May 12, 2024
| description = "OpenFisca Rules as Code model for Country-Template." | ||
| readme = "README.md" | ||
| license = {file = "LICENSE"} |
There was a problem hiding this comment.
If you are using a standard, well-known license, it is not necessary to use this field. Instead, you should one of the classifiers starting with License ::.
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
|
To clarify: the licence information is redundant and according to the doc we should use classifiers. If you want to get the PR to focus on reordering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.