Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade OpenAPI spec to v3 #128

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Upgrade OpenAPI spec to v3 #128

merged 5 commits into from
Dec 12, 2022

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Nov 3, 2022 •
edited
Loading

New Features

  • Upgrade OpenAPI specification of the API to v3 from Swagger v2.
  • Continuously validate OpenAPI specification.

Breaking changes

  • Drop support for OpenAPI specification v2 and prior.
  • Users relying on the aforesaid can use this to migrate (example).

screenshot

MattiSG
MattiSG requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the requested changes here (blocking but trivial, basically just CHANGELOG copy), this is blocked until https://github.com/openfisca/legislation-explorer/ is updated to support OpenAPI v3, as https://demo.openfisca.org will automatically deploy the latest version of this package.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@MattiSG
Copy link
Member

MattiSG commented Nov 14, 2022

Depends on openfisca/openfisca-core#989.

@MattiSG MattiSG mentioned this pull request Nov 14, 2022
Closed
@bonjourmauko bonjourmauko marked this pull request as draft December 7, 2022 18:00
@bonjourmauko
Copy link
Member Author

Beyond the requested changes here (blocking but trivial, basically just CHANGELOG copy), this is blocked until https://github.com/openfisca/legislation-explorer/ is updated to support OpenAPI v3, as https://demo.openfisca.org will automatically deploy the latest version of this package.

Legislation explorer already handles OpenAPI v3.

@MattiSG MattiSG marked this pull request as ready for review December 12, 2022 07:42
@MattiSG MattiSG merged commit a7f1176 into master Dec 12, 2022
@MattiSG MattiSG deleted the openapi-v3 branch December 12, 2022 07:45
@MattiSG MattiSG mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonjourmauko @MattiSG