This repository has been archived by the owner on May 24, 2022. It is now read-only.
misc: Move types. Renaming/typos in comments. Fix linting errors. Add license headers. Add FIXMEs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… license headers. Add FIXMEs
Pull Request Test Coverage Report for Build 229
💛 - Coveralls |
amaury1093
suggested changes
Nov 12, 2018
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2015-2017 Parity Technologies (UK) Ltd. | |||
| // Copyright 2015-2018 Parity Technologies (UK) Ltd. | |||
There was a problem hiding this comment.
Can you rebase on top of master? I merged the other one.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| import BigNumber from 'bignumber.js'; | |||
|
|
|||
| import { BlockNumber } from '../types'; | |||
| import { BlockNumber, InputDeriveHashMap, InputOptions, InputOptionsConditions, InputTrace, InputTraceHashMap } from '../types'; | |||
There was a problem hiding this comment.
I prefer in this PR to not touch anything in packages/api. This package needs some bigger effort to make it clean, see #21.
| @@ -3,7 +3,7 @@ | |||
| // | |||
| // SPDX-License-Identifier: MIT | |||
|
|
|||
| import { Api } from './types'; | |||
| import { Api } from '@parity/api/src/types'; | |||
There was a problem hiding this comment.
Same, please don't use anything from @parity/api for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove no longer used packages/contracts types file
Rename Ethcore to Parity
Change license header from 2017 to 2018 validity
Create Input___ types in packages/api to fix linting errors
Fix typo 'receiving' and 'initialises'
Rename 'pubsub' to 'pub-sub', 'rpc' to 'RPC', and 'abi' to 'ABI', and 'ether' to 'Ether' (when referring to denomination), and 'electron' to 'Electron', and 'parity' to 'Parity' or 'Parity Ethereum' (as applicable) in comments. Refer to 'parity binary' as '
paritybinary'Move types Api, Contract, and ContractInstance to '@parity/api/src/types'
Reword to 'The message of the RPC call.'
FIXME added since cannot find file '../../test/e2e/ethapi' used in unit test
FIXME added for test description 'returns and the chain'