feat: api migration

[volodymyr-chekyrta]

Migration API endpoints from the RG API plugin to the edx-platform upstream.

[openedx-webhooks]

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[omerhabib26]

I have started its review

[omerhabib26]

CourseDetailInfo isn't working else only some minor nits.
Suggestion: IMO, For the APIs we can define their versions in Config.yaml.

[omerhabib26]

we can also pass the api_version in params
i.e,

    @GET("/api/mobile/{api_version}/users/{username}/course_enrollments/")
    suspend fun getEnrolledCourses(
        @Header("Cache-Control") cacheControlHeaderParam: String? = null,
        @Path("api_version") apiVersion: String,
        @Path("username") username: String,
        @Query("org") org: String? = null,
        @Query("page") page: Int
    ): CourseEnrollments

[volodymyr-chekyrta]

I believe it's a great suggestion 👍👍👍
It might be beneficial to handle this improvement in a separate pull request to include a user API version to the config as well.
What do you think?

[omerhabib26]

sure,
@moiz994 can you please create a ticket for these improvements ?

[omerhabib26]

No need to create the ticket for now, we will handle it later

[volodymyr-chekyrta]

@omerhabib26, thank you for review!
Ready for another pass.

[omerhabib26]

Only a minor suggestion else LGTM 🚀

[omerhabib26]

/api/mobile/v3/course_info/ API not working and giving 400

[volodymyr-chekyrta]

/api/mobile/v3/course_info/ API not working and giving 400

The API has been changed and PR is now ready for review

[omerhabib26]

Some APIs are failing in case of course expiry we need to handle them properly

[omerhabib26]

This condition doesn't work properly with the expired course and shows an API loading error.
CourseStatusInfo, CourseDates, and Topis API are failing due to course expiry. I guess we can update this change with the following for now. We also need to update the message on NoAccessScreen accordingly. Right now it showing The Course hasn't started yet for every case.

        viewModel.dataReady.observe(viewLifecycleOwner) { coursewareAccess ->
            if (coursewareAccess != null && coursewareAccess.hasAccess) {
                initViewPager()
            } else {
                router.navigateToNoAccess(
                    requireActivity().supportFragmentManager,
                    courseTitle
                )
            }
        }

[omerhabib26]

I guess we can revert this change and handle it properly

[volodymyr-chekyrta]

Some APIs are failing in case of course expiry we need to handle them properly

I know about this case. We encountered a similar problem in the iOS PR openedx/openedx-app-ios#213 and decided to address it in a separate PR.
At the moment, I'm uncertain how to handle this case since we don't have coursewareAccess data.
It's possible that addressing this issue will require modifying the API.
Therefore, I suggest we tackle this later in a separate PR to avoid getting blocked now while waiting for the API.

[openedx-webhooks]

@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.