Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct exam entry check not called #147

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

zacharis278
Copy link
Contributor

@zacharis278 zacharis278 commented Jul 11, 2024

  1. Resolved issue where the exam entry check for the Proctoring software was not being executed. Seems like we missed a dispatch() call here when doing some redux refactoring a few months ago and this broke.
  2. Fixes an edge case where if the backend moves to a terminated state in a way that isn't caused by a client error the frontend does not show the correct interstitial message.

2U-internal Issue: COSMO-291

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (db51931) to head (8ed052b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   94.06%   94.16%   +0.09%     
==========================================
  Files          68       68              
  Lines        1079     1080       +1     
  Branches      295      295              
==========================================
+ Hits         1015     1017       +2     
+ Misses         59       58       -1     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alangsto alangsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zacharis278 zacharis278 merged commit c41adcb into main Jul 11, 2024
8 checks passed
@zacharis278 zacharis278 deleted the zhancock/fix-entry-check branch July 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants