[BD-46] feat: added support Paragon design tokens #303
Conversation
openedx-webhooks
added
the
blended
|
Thanks for the pull request, @PKulkoRaccoonGang! This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/support-design-tokens
branch
from
854fb53
to
9edae71
Compare
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/support-design-tokens
branch
from
9edae71
to
1b0fa1f
Compare
This PR purpose is to test/demo parago design tokens simliar to this one for the profile openedx/frontend-app-profile/pull/764 it override the following depns as seen in package.json - paragon alpha - openedx/frontend-build/pull/365 - openedx/frontend-platform/pull/440 - openedx/frontend-component-header/pull/351 - openedx/frontend-component-footer/pull/303 Conclousion so far: - There is an extra library that learning depends on which needs to support paragon; `frontend-lib-learning-assistant` and also `frontend-lib-special-exams` - It would be great to have a gudie or a document to look at, while doing the conversion that would **map variable from who it was used/named before to the name in design tokens** - I was stuck in the end with compliation error, that wepack couldn't find `Modal` exported from paragon.
|
Hey @PKulkoRaccoonGang, What is the current status of this PR, is it ready to review and merge? |
1 similar comment
|
Hey @PKulkoRaccoonGang, What is the current status of this PR, is it ready to review and merge? |
|
hi @PKulkoRaccoonGang is this PR still active or should we close it? |
|
@Mashal-m @abdullahwaheed Hello! At the moment, all pull requests opened in the edx and openex repositories are awaiting further action on the use of Paragon design tokens in the MFE. Don't pay any attention to them for now. Full list of pull requests that should just be open for now: |
|
Hi @PKulkoRaccoonGang, thanks for this. I checked these changes and it is still relevant, the only thing left to do is rebase to master, and once the new packages are created update frontend-platform and paragon. Also with the changes in frontend-build the webpack.dev.config.js needs a change for the example app, the change is only in the entry key: entry: {
app: path.resolve(__dirname, 'example'),
}, |
| @import "@edx/brand/paragon/variables"; | ||
| @import "@edx/paragon/scss/core/core"; | ||
| @import "@edx/brand/paragon/overrides"; | ||
|
|
||
| @import "@edx/frontend-component-footer/footer"; |
There was a problem hiding this comment.
| @import "@edx/frontend-component-footer/footer"; | |
| @use "@openedx/paragon/dist/core.min.css" as paragonCore; | |
| @use "@openedx/paragon/dist/light.min.css" as paragonLight; | |
| @import "@edx/frontend-component-footer/footer"; |
For the example app, I think we can use the Paragon installed versions, in this way, it's not necessary to add a js config file, and the styles are applied only for the example app.
dcoa
force-pushed
the
Peter_Kulko/support-design-tokens
branch
from
1b0fa1f
to
63c4dca
Compare
dcoa
force-pushed
the
Peter_Kulko/support-design-tokens
branch
from
63c4dca
to
e97fb66
Compare
Issue: openedx/paragon#2348