Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reskin of Profile MFE main page #1114

Open
wants to merge 8 commits into
base: 2u-main
Choose a base branch
from
Open

feat: reskin of Profile MFE main page #1114

wants to merge 8 commits into from

Conversation

eemaanamir
Copy link

@eemaanamir eemaanamir commented Oct 24, 2024

Ticket: INF-1570

Reskinning the Profile MFE main page according to the provided Figma.

Before:

58ff4399398be30e272fca6cbd82712d

After:

localhost_1995_u_edx

@eemaanamir eemaanamir requested a review from a team as a code owner October 24, 2024 14:07
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 71.51335% with 96 lines in your changes missing coverage. Please review.

Project coverage is 68.35%. Comparing base (a134083) to head (07e0ec8).
Report is 2 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/profile-v2/data/services.js 11.11% 45 Missing and 3 partials ⚠️
src/profile-v2/forms/ProfileAvatar.jsx 65.00% 14 Missing ⚠️
src/profile-v2/data/sagas.js 82.22% 7 Missing and 1 partial ⚠️
src/profile-v2/Certificates.jsx 72.00% 7 Missing ⚠️
src/index.jsx 0.00% 4 Missing ⚠️
src/profile-v2/ProfilePage.jsx 90.69% 4 Missing ⚠️
src/data/reducers.js 0.00% 2 Missing ⚠️
src/data/sagas.js 0.00% 2 Missing ⚠️
src/profile-v2/NotFoundPage.jsx 0.00% 2 Missing ⚠️
src/profile-v2/data/constants.js 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1114      +/-   ##
===========================================
+ Coverage    67.12%   68.35%   +1.23%     
===========================================
  Files           51       70      +19     
  Lines          864     1201     +337     
  Branches       179      254      +75     
===========================================
+ Hits           580      821     +241     
- Misses         274      366      +92     
- Partials        10       14       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant