Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add header styles inclusion #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lunyachek
Copy link

@Lunyachek Lunyachek commented Mar 14, 2024

Header styles inclusion like it done in frontend-app-learning - https://github.com/openedx/frontend-app-learning/blob/master/src/index.scss#L7

It can be useful, for example, for the potential using of cookie banner

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 14, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 14, 2024

Thanks for the pull request, @Lunyachek!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (567a020) to head (bd6e697).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          111       111           
  Lines         1082      1082           
  Branches       159       159           
=========================================
  Hits          1082      1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feanil feanil requested review from a team and removed request for a team March 20, 2024 15:07
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, but I wonder what the impact is, visually. I can find some header-specific CSS here, and I'm worried that bringing in the default styles will break them, somehow.

Can we get before-after screenshots?

@mphilbrick211
Copy link

Hi @Lunyachek! Just following up on this.

@mphilbrick211
Copy link

Sorry... didn't mean to close!

@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 1, 2024
@Lunyachek
Copy link
Author

Sorry for delay. @arbrandes I added screenshots

Before
Снимок экрана 2024-05-30 в 11 23 35

and after
Снимок экрана 2024-05-30 в 11 23 07

The included header styles don't affect the styles described in ORA MFE

@mphilbrick211
Copy link

@arbrandes - flagging the above!

@mphilbrick211 mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 30, 2024
@Lunyachek Lunyachek force-pushed the lunyachek/feat/header-styles-inclusion-master branch from 9189028 to bd6e697 Compare September 11, 2024 09:45
@Lunyachek
Copy link
Author

@arbrandes Hello! Friendly ping on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

4 participants