Merge pull request #294 from openedx/ahtesham/van-1832

fix: replace username with full name in the learner record title
openedx · Apr 4, 2024 · 4445fe3 · 4445fe3
2 parents 323ea5d + 22c4c9c
commit 4445fe3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/components/ProgramRecord/ProgramRecordHeader.jsx b/src/components/ProgramRecord/ProgramRecordHeader.jsx
@@ -77,15 +77,18 @@ function ProgramRecordHeader({
         </span>
       </div>
       <div className="learner-info my-3">
-        <FormattedMessage
-          id="learner.username"
-          defaultMessage="{username}"
-          description="Username of the learner"
-          values={{
-            username: learner.username,
-          }}
-        />
-        |
+        {
+          learner.full_name && (
+          <FormattedMessage
+            id="learner.full_name"
+            defaultMessage="{full_name} | "
+            description="Full name of the learner"
+            values={{
+              full_name: learner.full_name,
+            }}
+          />
+          )
+        }
         <FormattedMessage
           id="learner.email"
           defaultMessage="{email}"
@@ -103,7 +106,6 @@ ProgramRecordHeader.propTypes = {
   learner: PropTypes.shape({
     email: PropTypes.string,
     full_name: PropTypes.string,
-    username: PropTypes.string,
   }).isRequired,
   program: PropTypes.shape({
     name: PropTypes.string,

diff --git a/src/components/ProgramRecord/test/__factories__/programRecord.factory.js b/src/components/ProgramRecord/test/__factories__/programRecord.factory.js
@@ -3,7 +3,7 @@ import { Factory } from 'rosie'; // eslint-disable-line import/no-extraneous-dep
 export default Factory.define('program_record_details')
   .attr('record', {
     learner: {
-      full_name: '',
+      full_name: 'test',
       username: 'edx',
       email: '[email protected]',
     },