Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added dropdowns for v2 #815

Open
wants to merge 1 commit into
base: zafzal/ENT7364
Choose a base branch
from
Open

Conversation

zamanafzal
Copy link
Member

@zamanafzal zamanafzal commented Aug 29, 2023

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Screen Shot 2023-08-29 at 8 17 13 PM
Screen Shot 2023-08-30 at 4 42 39 PM

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 10.52% and project coverage change: -0.43% ⚠️

Comparison is base (dc44829) 84.80% compared to head (59932b6) 84.38%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           zafzal/ENT7364     #815      +/-   ##
==================================================
- Coverage           84.80%   84.38%   -0.43%     
==================================================
  Files                 328      329       +1     
  Lines                6682     6661      -21     
  Branches             1624     1614      -10     
==================================================
- Hits                 5667     5621      -46     
- Misses                983     1008      +25     
  Partials               32       32              
Files Changed Coverage Δ
src/components/skills-quiz-v2/SkillsQuiz.jsx 3.70% <0.00%> (-1.30%) ⬇️
src/components/skills-quiz-v2/GoalDropdown.jsx 12.50% <12.50%> (ø)
.../components/skills-quiz-v2/AutoSuggestDropDown.jsx 25.00% <25.00%> (ø)

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the screenshots of the new dropdowns.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the border from this link, because it looks a bit weird to me?
image

@zamanafzal
Copy link
Member Author

zamanafzal commented Aug 30, 2023

@jajjibhai008 There is no border here. It's showing due to the cursor being here while taking the screenshot. I have updated the image in PR.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the coverage issues. Other than that LGTM 👍

@zamanafzal
Copy link
Member Author

This is just for the sake of design. It will go to frontend-enterprise. That's why tests are not added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants