Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade frontend-build, patch font-awesome, use React.StrictMode, refactor dashboard tabs #777

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adamstankiewicz
Copy link
Member

Description

  • Upgrades @edx/frontend-build to latest (v12.8.57).
  • Patches font-awesome via patch-package (docs).
    • Adds an ADR to add context for the decision to patch font-awesome.
  • Begins running the application in React.StrictMode (docs). By doing so, we should be able to identify and fix any issues now to make future React upgrades easier (and to take advantage of React features like concurrent rendering). Upon running the application locally with React.StrictMode, the behavior doesn't appear to be any different, so this feels like a safe enough change for now.
    • React.StrictMode only impacts the application when running in development; does not affect production builds.
  • Refactors the DashboardPage tabs to rely on an array as its children due to the conditional feature flags used as currently implemented. If those feature flags are false, it would break the Tabs component which expects every child node to be a Tab component (i.e., not a boolean).

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@adamstankiewicz adamstankiewicz changed the title chore: patch font-awesome, run React.StrictMode chore: upgrade frontend-build, patch font-awesome, run React.StrictMode Jun 25, 2023
@adamstankiewicz adamstankiewicz changed the title chore: upgrade frontend-build, patch font-awesome, run React.StrictMode chore: upgrade frontend-build, patch font-awesome, use React.StrictMode, refactor dashboard tabs Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.19 ⚠️

Comparison is base (d36b78a) 84.87% compared to head (2e9574b) 84.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
- Coverage   84.87%   84.68%   -0.19%     
==========================================
  Files         320      322       +2     
  Lines        6399     6557     +158     
  Branches     1552     1594      +42     
==========================================
+ Hits         5431     5553     +122     
- Misses        941      975      +34     
- Partials       27       29       +2     
Impacted Files Coverage Δ
.../components/course/course-header/CourseRunCard.jsx 100.00% <ø> (ø)
...ourse-header/data/hooks/useCourseRunCardAction.jsx 100.00% <ø> (ø)
...e/course-header/data/hooks/useCourseRunCardData.js 100.00% <ø> (ø)
src/components/course/data/service.js 46.51% <ø> (ø)
...rse/enrollment/components/ToDataSharingConsent.jsx 100.00% <ø> (ø)
.../course/enrollment/components/ToEcomBasketPage.jsx 75.00% <ø> (-1.93%) ⬇️
...nt/components/ToExecutiveEducation2UEnrollment.jsx 50.00% <0.00%> (ø)
src/components/course/enrollment/constants.js 100.00% <ø> (ø)
...oard/main-content/course-enrollments/data/hooks.js 100.00% <ø> (ø)
...xecutive-education-2u/ExecutiveEducation2UPage.jsx 100.00% <ø> (ø)
... and 29 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant