Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #408

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Sep 20, 2024

Note: As per openedx/public-engineering#280 this can merge after Sumac cut.

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 20, 2024
@BilalQamar95 BilalQamar95 requested a review from a team as a code owner September 20, 2024 09:55
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (cf5e1a6) to head (5aba677).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         139      139           
  Lines        1356     1356           
  Branches      265      265           
=======================================
  Hits         1288     1288           
  Misses         60       60           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farhaanbukhsh
Copy link
Member

farhaanbukhsh commented Oct 28, 2024

@BilalQamar95 Sumac is done :) maybe if you can rebase this PR we can merge this in.

@brian-smith-tcril brian-smith-tcril merged commit 215662b into master Oct 31, 2024
7 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node20-upgrade-3 branch October 31, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants