Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #319

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Mar 16, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi requested a review from a team as a code owner March 16, 2023 09:41
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Mar 16, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft March 16, 2023 09:41
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (5e96dbf) 94.93% compared to head (9da5f81) 94.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   94.93%   94.98%   +0.05%     
==========================================
  Files         139      140       +1     
  Lines        1343     1357      +14     
  Branches      264      264              
==========================================
+ Hits         1275     1289      +14     
  Misses         60       60              
  Partials        8        8              
Files Changed Coverage Δ
src/App.jsx 100.00% <ø> (ø)
src/containers/GradebookPage/index.jsx 100.00% <100.00%> (ø)
src/utils/hoc.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 30, 2023 12:04
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mattcarter mattcarter merged commit 247e9f3 into master Sep 18, 2023
5 checks passed
@mattcarter mattcarter deleted the Ali-Abbas/upgrade-react-router branch September 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants