Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated README file to reflect template changes #367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mashal-m
Copy link
Contributor

Description

The README of the MFEs needs to be updated because the frontend app template has been updated.

Issue related: openedx/wg-frontend#169

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6519c3d) 82.26% compared to head (83974b1) 82.49%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   82.26%   82.49%   +0.23%     
==========================================
  Files          38       38              
  Lines         716      714       -2     
  Branches      233      232       -1     
==========================================
  Hits          589      589              
+ Misses        123      121       -2     
  Partials        4        4              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review October 31, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant