Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #318

Merged
merged 10 commits into from
Aug 24, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 8, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with react-test-renderer, react-loading-skeleton, @fortawesome/react-fontawesome & @testing-library/react to respective compatible versions
  • Bumped edx packages

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch from d49a80d to 794a783 Compare July 25, 2023 07:59
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b33e06) 82.49% compared to head (136f1f1) 82.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files          38       38           
  Lines         697      697           
  Branches      219      219           
=======================================
  Hits          575      575           
  Misses        118      118           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review July 25, 2023 09:21
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if build is passing then this looks good to me

@BilalQamar95
Copy link
Contributor Author

if build is passing then this looks good to me

Double checked, build is passing. Merging this

@BilalQamar95 BilalQamar95 merged commit 9716af2 into main Aug 24, 2023
5 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/react-upgrade-to-v17 branch August 24, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants