-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent wrong appearance of skeleton after second tab click #1224
base: open-release/quince.master
Are you sure you want to change the base?
fix: Prevent wrong appearance of skeleton after second tab click #1224
Conversation
Thanks for the pull request, @Lunyachek! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @openedx/2u-vanguards! This is ready for review. Thanks! |
Hi @openedx/2u-vanguards! Just following up on this. |
Friendly ping on this @openedx/2u-vanguards @openedx/vanguards |
HI @mphilbrick211. Vanguards is no longer the maintainer of this repo. New owners are nominated but not officially updated. It will be notified soon |
This is backport form master - #1086
Description
We found that after clicking twice on the same tab - skeleton appeared and not disappeared till switching other tab or page refresh. We think that it is not logical and our proposal - this minor fix
Before fix:
2023-10-21.22.00.50-2.mov
After fix:
2023-10-21.22.03.33.mov
Merge Checklist
Post-merge Checklist