Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds flex groups dropdown menu in assignment modal #1335

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Oct 15, 2024

Description

Adds support for admins to select flex groups from the dropdown menu to the Learner credit assignment modal. The members associated with that group will be added to the summary tab once the user clicks the Apply selections button.
If a group does not have any flex groups, the dropdown will not be shown.

https://2u-internal.atlassian.net/browse/ENT-9491

Screen.Recording.2024-10-22.at.4.52.11.PM.mov

Test scenarios

  1. checkout this branch and visit customer page https://localhost.stage.edx.org:1991/alc-general/admin/learner-credit/7f344aea-c28c-4ef0-95e6-fb6e58f98495/assign to choose one of the courses to assign learners to.
  2. verify that if the user clicks on a group but does not the Apply selections button and navigates away from the dropdown menu, the selections will clear. The same should apply when the user unchecks a group that was previously added to the summary tab -- previous selections/unselections should persist until the user clicks the 'Apply selections' button.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 changed the title Knguyen2/ent 9491 feat: adds flex groups dropdown menu in assignment modal Oct 22, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 86.17021% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.73%. Comparing base (4f9d197) to head (f1f38ee).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...it-management/data/hooks/useGroupDropdownToggle.js 75.60% 6 Missing and 4 partials ⚠️
...t-management/data/hooks/useEnterpriseFlexGroups.js 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1335   +/-   ##
=======================================
  Coverage   85.72%   85.73%           
=======================================
  Files         594      597    +3     
  Lines       12977    13071   +94     
  Branches     2704     2766   +62     
=======================================
+ Hits        11125    11206   +81     
- Misses       1792     1800    +8     
- Partials       60       65    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 marked this pull request as ready for review October 23, 2024 00:04
@katrinan029 katrinan029 requested a review from a team October 23, 2024 18:04
@katrinan029 katrinan029 merged commit 4e72019 into master Oct 30, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9491 branch October 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants