fix: PR requests

openedx · Oct 16, 2024 · a6d24c2 · a6d24c2
1 parent 8b8bf32
commit a6d24c2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/src/components/ContentHighlights/ContentHighlights.jsx b/src/components/ContentHighlights/ContentHighlights.jsx
@@ -16,6 +16,7 @@ import ContentHighlightsContextProvider from './ContentHighlightsContext';
 import ContentHighlightToast from './ContentHighlightToast';
 import { EnterpriseAppContext } from '../EnterpriseApp/EnterpriseAppContextProvider';
 import { withLocation } from '../../hoc';
+import { GROUP_TYPE_BUDGET } from '../PeopleManagement/constants';
 
 const ContentHighlights = ({ location, enterpriseGroupsV1 }) => {
   const navigate = useNavigate();
@@ -31,7 +32,7 @@ const ContentHighlights = ({ location, enterpriseGroupsV1 }) => {
       try {
         const response = await LmsApiService.fetchEnterpriseGroups();
         response.data.results.forEach((group) => {
-          if (group.group_type === 'budget') {
+          if (group.group_type === GROUP_TYPE_BUDGET) {
             setHasBudgetGroup(true);
           }
         });

diff --git a/src/components/ContentHighlights/tests/ContentHighlights.test.jsx b/src/components/ContentHighlights/tests/ContentHighlights.test.jsx
@@ -10,6 +10,7 @@ import { IntlProvider } from '@edx/frontend-platform/i18n';
 import ContentHighlights from '../ContentHighlights';
 import { EnterpriseAppContext } from '../../EnterpriseApp/EnterpriseAppContextProvider';
 import LmsApiService from '../../../data/services/LmsApiService';
+import { GROUP_TYPE_BUDGET } from '../../PeopleManagement/constants';
 
 jest.mock('../../../data/services/LmsApiService');
 
@@ -86,7 +87,7 @@ describe('<ContentHighlights>', () => {
   });
   it('Displays the alert if custom groups is enabled and user is staff', () => {
     LmsApiService.fetchEnterpriseGroups.mockImplementation(() => Promise.resolve({
-      data: { results: [{ group_type: 'budget' }] },
+      data: { results: [{ group_type: GROUP_TYPE_BUDGET }] },
     }));
     renderWithRouter(<ContentHighlightsWrapper location={{ state: {} }} />);
   });

diff --git a/src/components/PeopleManagement/constants.js b/src/components/PeopleManagement/constants.js
@@ -1,2 +1,4 @@
-const MAX_LENGTH_GROUP_NAME = 60;
-export default MAX_LENGTH_GROUP_NAME;
+export const MAX_LENGTH_GROUP_NAME = 60;
+
+export const GROUP_TYPE_BUDGET = 'budget';
+export const GROUP_TYPE_FLEX = 'flex';
diff --git a/src/components/Sidebar/index.jsx b/src/components/Sidebar/index.jsx
@@ -22,6 +22,7 @@ import { useOnMount } from '../../hooks';
 import { EnterpriseSubsidiesContext } from '../EnterpriseSubsidiesContext';
 import { EnterpriseAppContext } from '../EnterpriseApp/EnterpriseAppContextProvider';
 import LmsApiService from '../../data/services/LmsApiService';
+import { GROUP_TYPE_BUDGET } from '../PeopleManagement/constants';
 
 const Sidebar = ({
   baseUrl,
@@ -89,7 +90,7 @@ const Sidebar = ({
         // we only want to hide the feature if a customer has a group this does not
         // apply to all contexts/include all users
         response.data.results.forEach((group) => {
-          if (group.group_type === 'budget') {
+          if (group.group_type === GROUP_TYPE_BUDGET) {
             setHasBudgetGroup(true);
           }
         });