Merge pull request #1255 from openedx/eahmadjaved/ENT-9005

feat: add github check to validate i18n string extraction
openedx · Jun 21, 2024 · a29388e · a29388e
2 parents 7480cb0 + 5bf795c
commit a29388e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -24,6 +24,8 @@ jobs:
       run: npm ci
     - name: Lint
       run: npm run lint
+    - name: extract_translations
+      run: make extract_translations
     - name: Test
       run: npm run test
     - name: Coverage

diff --git a/package.json b/package.json
@@ -8,7 +8,7 @@
   ],
   "scripts": {
     "build": "fedx-scripts webpack",
-    "i18n_extract": "fedx-scripts formatjs extract",
+    "i18n_extract": "fedx-scripts formatjs extract --throws",
     "build:with-theme": "THEME=npm:@edx/brand-edx.org@latest npm run install-theme && fedx-scripts webpack",
     "check-types": "tsc --noemit",
     "lint": "fedx-scripts eslint --ext .js --ext .jsx .; npm run check-types",