Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated copy change on Name Change modal #1108

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Aug 21, 2024

Description

Just a copy change on the Name Change modal. This is part of the New IDV vendor work openedx/platform-roadmap#367.

Old copy:

Enter your name as it appears on your unexpired student, work, or government-issued identification card.

New copy:

Enter your name as it appears on your identification card.

How Has This Been Tested?

Tested locally.

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@rijuma rijuma marked this pull request as ready for review August 21, 2024 12:28
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.61%. Comparing base (c5c05c8) to head (11d7d4b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   58.61%   58.61%           
=======================================
  Files         117      117           
  Lines        2317     2317           
  Branches      641      644    +3     
=======================================
  Hits         1358     1358           
  Misses        898      898           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - agree with Zach about the duplicate.

Could you link to the openedx/platform-roadmap#367 issue in your pull request description, briefly explain that we are doing this to generalize the copy, and request the Infinity team for a review, please?

Copy link
Contributor

@ayesha-waris ayesha-waris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@rijuma rijuma merged commit f81ec95 into master Aug 27, 2024
12 checks passed
@rijuma rijuma deleted the rijuma/verify-copy-change branch August 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants