Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bok-choy usage #447

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

salman2013
Copy link
Contributor

Description

As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.

Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=45253005

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c897be7) 81.72% compared to head (51bbdc0) 81.72%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   81.72%   81.72%           
=======================================
  Files          24       24           
  Lines        1302     1302           
=======================================
  Hits         1064     1064           
  Misses        238      238           
Flag Coverage Δ
unittests 81.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coverage.xml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be checked in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly committed this file, removed now.

@feanil feanil merged commit 3f1bc2a into openedx:master Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants