-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: certificate display behavior not showing date-picker for end-with-date #35675
fix: certificate display behavior not showing date-picker for end-with-date #35675
Conversation
Thanks for the pull request, @Anas12091101! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
be84eb0
to
7cdb0ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thanks for putting up a fix of this.
I've tested the functionality as well and here are the details:
- I was able to see the date picker when after selecting
A date after the course end date
- I was able to set a date and save settings in Studio
- I was able to get the certificate available date in the API
/api/courses/v1/courses/<course_id>
. - I have tested the behavior of this field with Self-paced courses where it should not be displayed but you have to refresh the page when you switch course pacing to actually notice the correct behavior. This was the same behavior prior to v2 certificate setting removal.
- Also, The date doesn't persist It's value when you change pacing or select some other certificate display behavior. This was the same behavior prior to v2 certificate setting removal.
@Anas12091101 can you rebase this? |
3e6a09c
to
d96f197
Compare
d96f197
to
fb5e269
Compare
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
#35562 has been merged recently removing
use_v2_cert_display_settings
. However,useV2CertDisplaySettings
was left to be removed from the backbone JS files. This resulted in a bug of not showing the date-picker when Certificate Display Behaviour was set toend-with-date
. This PR solves this issue and removes all the usage ofuseV2CertDisplaySettings
from backbone JS files.Useful information to include:
Before:
After:
Supporting information
https://github.com/mitodl/hq/issues/5792
Testing instructions
certificates.auto_certificate_generation
waffle switch in edx-platformSchedule and Details
in the settings tab.A date after the course end date
from theCertificates Display Behavior
options.Certificates Available Date
should be displayed next toCertificates Display Behavior
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.