fix: Remove duplicated (unclosed) section tag #35301
Conversation
|
Thanks for the pull request, @rediris! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
mphilbrick211
added
the
needs test run
There was a problem hiding this comment.
Thanks for the fix @rediris . Once you sign the CLA, I'll merge this.
mphilbrick211
removed
the
needs test run
added logs for data dog inspection for permission check in handler function. Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
feat: added migration for model updateroleassignmentswithcustomersconfig Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
This reverts commit 2659ae9.
* Revert "fix: change settings config to empty list not dict" This reverts commit b65550c. * Revert "fix: dependencies again" This reverts commit c06416b. * Revert "feat: updated user retirement docs" This reverts commit c9641b3. * Revert "fix: install dependencies" This reverts commit a5442b2. * Revert "Revert "fix: dependencies"" This reverts commit 4cde950. * Revert "fix: dependencies" This reverts commit 8a1c30e. * Revert "fix: Add CI update for tests" This reverts commit 64098b6. * Revert "fix: tests" This reverts commit 5e636de. * Revert "fix: generalize internal services" This reverts commit e8f9db4. * Revert "fix: quality" This reverts commit 77ca0f7. * Revert "feat: Commerce Coordinator step in retirement pipeline" This reverts commit c24c874.
…api (openedx#35084) * feat: upgrading simple api to drf compatible.
Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
Co-authored-by: Kira Miller <[email protected]>
…ontent (openedx#35111) * feat: upgrading simple api to drf compatible.
) * fix: Respect the authsource kwarg for MongoDB connections The changes for upgrading to PyMongo 4.4 introduced an authentication bug in Mongo connections. The `authSource` parameter was being hard-coded to use the database being connected to. In Mongo the `admin` db is typically the source of authentication, so unless the user was explicitly created in the target db then any attempts to connect would result in authentication failures. This restores the behavior of allowing for the lowercased `authsource` kwarg to be used for the `authSource` connection parameter, while otherwise respecting the operator's configuration parameters. * fix: Respect the authsource kwarg for MongoDB connections The changes for upgrading to PyMongo 4.4 introduced an authentication bug in Mongo connections. The `authSource` parameter was being hard-coded to use the database being connected to. In Mongo the `admin` db is typically the source of authentication, so unless the user was explicitly created in the target db then any attempts to connect would result in authentication failures. This restores the behavior of allowing for the lowercased `authsource` kwarg to be used for the `authSource` connection parameter, while otherwise respecting the operator's configuration parameters.
I'm about to make a bunch of changes to this file, and before I do I'm saving it and letting the linter reformatted to our current code style standards, so that code reviewers won't have to read a mix of lint and code changes. FIXES: APER-3554
…edx#35219)" (openedx#35349) This reverts commit 5c09424.
…edx#35138) * chore: provide logo url from backend for batch enrollment email
Editing this file is going to cause a lot of automatic linting, so lint-only commit for nicer code review.
This commits adds a VerificationAttempt model to store implementation and provider agnostic information about identity verification attempts in the platform.
added encrypted columns for user credentials for SAP config Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
…openedx#35148) * feat: upgrading simple api to drf compatible.
This PR fixes the accessibility issues associated with only visually treating the current transcript line. The current implementation for the transcript panel bolds the text that is actively being spoken or skipped to. However, there is no aria attribute present to convey this change to assistive technology. This change impacts learners and course authors.
|
@rediris Were you able to sign the CLA? That's the only thing blocking me from merging your contribution. No need to worry about the committlint failures. Those are happening because of the Merge commits, but when I merge your PR I will squash those all away. |
rediris
force-pushed
the
fix/duplicated-unclosed-markup
branch
from
443bcec
to
2c66cf0
Compare
|
Hi @kdmccormick I did send a CLA request, but I don't know where I am in the process. I'm going to scrap this PR and start over - this rebasing is turning into too much of a headache. |
|
Closing to redo the PR. |
|
@rediris Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
## Description This PR removes some bad (duplicated) markup in the static tab file. The current behavior leads to an unclosed HTML tag, which can be confirmed by viewing the document source. --- See original, abandoned PR here: openedx#35301 See a 2nd abandoned PR here: openedx#35382
Description
This PR removes some bad (duplicated) markup in the static tab file. The current behavior leads to an unclosed HTML tag, which can be confirmed by viewing the document source.