feat: remove unused JS requirement in CMS

[bradenmacdonald]

Description

In the legacy Studio UI's JS console on a tutor devstack, a couple 404 errors can be seen:

I believe this error has been there for a long time, without causing any issues. That is, the legacy Studio UI does not seem to depend on the Bootstrap (or popper) JS.

Some LMS legacy UI pages do depend on bootstrap+popper, which they get from

edx-platform/lms/templates/main.html

Lines 117 to 120 in 68b3753

	% if uses_bootstrap:
	## xss-lint: disable=mako-invalid-js-filter
	<script type="text/javascript" src="${static.url('common/js/vendor/bootstrap.bundle.js')}"></script>
	% endif

if needed. This file is not part of the repo's source code, but is created by

edx-platform/scripts/copy-node-modules.sh

Line 58 in 68b3753

"$node_modules/bootstrap/dist/js/bootstrap.bundle.js" \

Testing instructions

You can go to the "bookmarks" page of a course in the legacy LMS UI (which is a page that uses bootstrap's JS), e.g. http://local.overhang.io:8000/courses/course-v1:A+B+C/bookmarks/ and in the JS console you can run $.fn.modal and $.fn.carousel to verify that Bootstrap's JS is active.

But, with or without the changes in this PR, if you run those same commands in any legacy Studio UI page, you'll see that Bootsrap's JS is not loaded, but the UI works fine.

Likewise on any production instance, you won't see the 404 error because popper/bootstrap are simply missing from the generated bundle cms-base-vendor.x.js. But you can open a JS console and verify that e.g. $.fn.modal and $.fn.carousel are not loaded on the page.

Deadline

None

Other information

[openedx-webhooks]

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[bradenmacdonald]

@brian-smith-tcril FYI

[mphilbrick211]

@bradenmacdonald @brian-smith-tcril - is this still in progress?

[bradenmacdonald]

@mphilbrick211 I would still like to merge this, if @brian-smith-tcril or maybe @kdmccormick could review it.

[kdmccormick]

Thanks Braden!

[kdmccormick]

nit: you could merge this in as a refactor:commit so that Chris doesn't see it when compiling release notes. Or perf: if you feel that's appropriate.

[bradenmacdonald]

I'm planning to merge this on Tuesday.

[openedx-webhooks]

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.