Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove the django-splash app. #34528

Merged
merged 3 commits into from
Apr 19, 2024
Merged

feat!: Remove the django-splash app. #34528

merged 3 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. feat!: Remove the django-splash app. 

    DEPR: openedx/public-engineering#224

The django-splash repo was created 11 years ago to let the LMS redirect
users to a splash screen when a user comes to the site for the first
time. It works by looking for a configurable cookie value and
redirecting from the middleware.

This feature was never documented, has some edx.org hardcoded defaults,
and is not compatible with MFEs.

BREAKING CHANGE: The django splash feature will no longer be available.
    @feanil
    feanil committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    cec7969 View commit details
    Browse the repository at this point in the history

  2. chore: Run make compile-requirements to drop django-splash.

    @feanil
    feanil committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    83ace4d View commit details
    Browse the repository at this point in the history

  3. test: Reduce query counts now that we dropped django-splash.

    @feanil
    feanil committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9bd4474 View commit details
    Browse the repository at this point in the history