Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0001: ecommerce Basket Page -> micro-frontend #30377

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

UvgenGen
Copy link
Contributor

@UvgenGen UvgenGen commented May 12, 2022

Description

Replace the Basket page with a new micro-frontend-based implementation: edx/frontend-app-payment

Supporting information

openedx/public-engineering#68
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-42
PR to ecommerce:
openedx-unsupported/ecommerce#3829
openedx-unsupported/ecommerce#3718

@openedx-webhooks
Copy link

openedx-webhooks commented May 12, 2022

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link
Contributor

@dianakhuang Can you review and check with Purchase team if they are ok with you reviewing/merging this ?

@bmtcril
Copy link
Contributor

bmtcril commented Sep 26, 2022

@UvgenGen I'm looking into why so many tests are getting cancelled, but the failing test looks legitimate. It wants makemigrations run for the change to the default text for CommerceConfiguration.basket_checkout_page.

E assert 'No changes detected' in "Migrations for 'commerce':\n lms/djangoapps/commerce/migrations/0009_alter_commerceconfiguration_basket_checkout_pag..., help_text='Path to course(s) checkout page hosted by the E-Commerce service.', max_length=255),\n ),\n ]\n"

@UvgenGen
Copy link
Contributor Author

@bmtcril Should I add a migration in this PR or add skip for this test and add a migration separately?

@bmtcril
Copy link
Contributor

bmtcril commented Sep 26, 2022

@UvgenGen it will need to be part of this PR.

@mphilbrick211
Copy link

@bmtcril - would you mind reviewing the latest commit?

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 16, 2022
@mphilbrick211
Copy link

Hi @bmtcril - just following up on this to see if this can be reviewed/merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

5 participants