-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0001: ecommerce Basket Page -> micro-frontend #30377
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@dianakhuang Can you review and check with Purchase team if they are ok with you reviewing/merging this ? |
7cf0e0a
to
24a6a52
Compare
24a6a52
to
4abc563
Compare
@UvgenGen I'm looking into why so many tests are getting cancelled, but the failing test looks legitimate. It wants makemigrations run for the change to the default text for
|
@bmtcril Should I add a migration in this PR or add skip for this test and add a migration separately? |
@UvgenGen it will need to be part of this PR. |
@bmtcril - would you mind reviewing the latest commit? |
Hi @bmtcril - just following up on this to see if this can be reviewed/merged? |
Description
Replace the Basket page with a new micro-frontend-based implementation: edx/frontend-app-payment
Supporting information
openedx/public-engineering#68
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-42
PR to ecommerce:
openedx-unsupported/ecommerce#3829
openedx-unsupported/ecommerce#3718