This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
fix: Retry deleting a branch if GitHub says it's unknown #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have 13 ambiguous 7-character abbreviated commit hashes:
```
$ git log --branches --tags --format=format:%H | grep -Po '^.{7}' | sort | uniq -c | grep -v ' 1 ' | wc -l
13
```
(and one collision for 8, even)
Try to fix #687 by allowing retries on `delete_branch`. This may prevent the issue we've seen in `create_private_to_public_pr.py` where the deletion of a newly created branch occasionally fails with a 404.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 74.70% 74.70%
=======================================
Files 105 105
Lines 8588 8588
=======================================
Hits 6416 6416
Misses 2172 2172
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
1 task
robrap
approved these changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #687 by allowing retries on
delete_branch. This may prevent the issue we've seen increate_private_to_public_pr.pywhere the deletion of a newly created branch occasionally fails with a 404.Also, avoid collisions in SHA prefixes by increasing from 7 to 12 chars. (See commit message for details.)