-
Notifications
You must be signed in to change notification settings - Fork 132
chore: remove bok-choy usage #1527
chore: remove bok-choy usage #1527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some more mixins in the acceptance test module that should also be cleaned up because they are no longer being used anywhere but other than that this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed one more thing but then I think this is good to go.
@@ -4,7 +4,6 @@ | |||
-r base.txt | |||
|
|||
astroid | |||
bok-choy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need selenium in this repo or should that be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not, i searched and removed it. thanks for pointing this.
Description:
As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.
Ticket : https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=43871848