This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
chore: update bok-choy hostname #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
reviewed
Oct 27, 2023
docker-compose-watchers.yml
Outdated
| @@ -5,7 +5,7 @@ services: | |||
| command: bash -c 'cd /edx/app/edxapp/edx-platform && source ../edxapp_env && while true; do paver watch_assets --w=$$ASSET_WATCHER_TIMEOUT; sleep 2; done' | |||
| container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.lms_watcher" | |||
| environment: | |||
| BOK_CHOY_HOSTNAME: edx.devstack.lms_watcher | |||
| SERVER_HOSTNAME: edx.devstack.lms_watcher | |||
There was a problem hiding this comment.
SERVER_HOSTNAME is very vague and generic, is there a better name we could use to describe what server we're referring to? Is this the LMS_SERVER? the FRONTEND_TEST_SERVER? KARMA_HOSTNAME? something else? Can you come up with a more descriptive name for this variable?
feanil
reviewed
Oct 30, 2023
feanil
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In this PR i update the BOK_CHOY_HOSTNAME to SERVER_HOSTNAME in the scope of removing bok-choy from edx-platform (openedx/public-engineering#13) ticket:https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=37830749, the reason to update the variable name is to intact the logic to choose browser for karma and remove all bok-choy setting either by name or functionality.