fix: check valid sct and sc combinations for pi error #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwakar Sharma <[email protected]>
tiagolobocastro
approved these changes
Oct 16, 2024
abhilashshetty04
approved these changes
Oct 17, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
1756: fix: check valid sct and sc combinations for pi error r=dsharma-dc a=dsharma-dc Fix the sct and sc combination checks. Don't see a reason why it would be valid as it stands today. This just floods the logs as we might log io completion as PI error, for unrelated status code values too. spdk handles the PI error as per this modified check. Co-authored-by: Diwakar Sharma <[email protected]>
|
Build failed: |
duplicate qid error :( |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the sct and sc combination checks. Don't see a reason why it would be valid as it stands today. This just floods the logs as we might log io completion as PI error, for unrelated status code values too.
spdk handles the PI error as per this modified check.