Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUGFIX ] Fabrics connect timeouts #1711

Merged
merged 5 commits into from
Aug 9, 2024

Commits on Aug 6, 2024

  1. feat: allow custom fabrics connect timeout

    Allows passing this via env NVMF_FABRICS_CONNECT_TIMEOUT.
    Also defaults it to 1s for now, rather than 500ms.
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b088f32 View commit details
    Browse the repository at this point in the history
  2. fix(nvmx/qpair): return errno with absolute value

    Otherwise a returned negative value translates into an unknown Errno.
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ec02339 View commit details
    Browse the repository at this point in the history
  3. fix(nexus-child/unplug): remove usage of block_on

    Initially this block_on was added because the remove callback was running in blocking
    fashion, but this has since changed and unplug is actually called from async context.
    As such, we don't need the block_on and simply call the async code directly.
    Also, simplify complete notification, as we can simply close the sender.
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ad5c31a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. fix(nvmf/target): remove usage of block_on

    Split creating from starting the subsystem.
    This way we can start the subsystem in master reactor, and then move
    to the next spdk subsystem.
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d5b5d44 View commit details
    Browse the repository at this point in the history
  2. chore: add warning to block_on

    Should this become an unsafe function?
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d9e19b3 View commit details
    Browse the repository at this point in the history