build: support podman for load/pushing container images #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
dsavitskiy,
sinhaashish,
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
By default docker is tried, and then podman. Support is simplistically verified with the exit code from --version First choice can be overridden with DOCKER env variable. Signed-off-by: Tiago Castro <[email protected]>
|
Making the same changes on all repos would be a pain, so instead I'm adding a common release script which all repos can make use of: openebs/mayastor-dependencies#88 |
|
bors try |
tryBuild succeeded: |
dsharma-dc
approved these changes
Jul 31, 2024
Abhinandan-Purkait
approved these changes
Jul 31, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
1703: build: support podman for load/pushing container images r=tiagolobocastro a=tiagolobocastro By default docker is tried, and then podman. Support is simplistically verified with the exit code from --version. First choice can be overridden with DOCKER env variable. Co-authored-by: Tiago Castro <[email protected]>
|
Build failed: |
Update to dependencies where a base release.sh is present which can be used by the various mayastor repos. Signed-off-by: Tiago Castro <[email protected]>
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default docker is tried, and then podman.
Support is simplistically verified with the exit code from --version.
First choice can be overridden with DOCKER env variable.