Refactor more explicit uses of Lvol with the backend interface #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Jul 26, 2024
•
tiagolobocastro
commented
tiagolobocastro
requested review from
dsavitskiy,
abhilashshetty04 and
dsharma-dc
|
bors try |
1 similar comment
|
bors try |
tiagolobocastro
force-pushed
the
refactor-ops
branch
from
5c1cdf2
to
ba74e48
Compare
tryTimed out. |
|
bors try |
tryBuild succeeded: |
dsharma-dc
reviewed
Aug 2, 2024
dsharma-dc
approved these changes
Aug 5, 2024
Use new ops interfaces rather than hardcoded lvs/lvol. This will help support stats for other pool backends. Signed-off-by: Tiago Castro <[email protected]>
Removes unused function still making use of Lvol. Probably not previously detected because it was being exposed as pub. Signed-off-by: Tiago Castro <[email protected]>
Move common code to the factories allowing us to reuse code between core components and grpc service. Signed-off-by: Tiago Castro <[email protected]>
Use traits rather than explicitly use Lvol. Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
refactor-ops
branch
from
c192e09
to
42682ad
Compare
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
1700: Refactor more explicit uses of Lvol with the backend interface r=tiagolobocastro a=tiagolobocastro
ci: use sudo to remove test files
Signed-off-by: Tiago Castro <[email protected]>
---
refactor(wipe): use new backend traits
Use traits rather than explicitly use Lvol.
Signed-off-by: Tiago Castro <[email protected]>
---
refactor(backends): reuse common factory code
Move common code to the factories allowing us to reuse code between
core components and grpc service.
Signed-off-by: Tiago Castro <[email protected]>
---
refactor(snapshot): remove unused create-snapshot
Removes unused function still making use of Lvol.
Probably not previously detected because it was being exposed as pub.
Signed-off-by: Tiago Castro <[email protected]>
---
refactor(stats): use new ops interface
Use new ops interfaces rather than hardcoded lvs/lvol.
This will help support stats for other pool backends.
Signed-off-by: Tiago Castro <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.